Skip to content

fix: keep the stored publiccode.yml when parsing fails - #55

Merged
bfabio merged 1 commit into
perf/reuse-github-org-listingfrom
fix/keep-stored-publiccode-on-parse-failure
Nov 13, 2026
Merged

bfabio merged 1 commit into
perf/reuse-github-org-listingfrom
fix/keep-stored-publiccode-on-parse-failure

Conversation

@bfabio

@bfabio bfabio commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

A YAML syntax error leaves the parser without a document. For known
active software the crawler still sent publiccodeYml as an empty string,
so the API overwrote the last stored file while keeping the software
active.

A YAML syntax error leaves the parser without a document. For known
active software the crawler still sent publiccodeYml as an empty string,
so the API overwrote the last stored file while keeping the software
active.

Omit the file from the PATCH when parsing returns no document, so the
API keeps the stored copy. Files that parse but fail validation are
still saved, as before.
@bfabio
bfabio added this pull request to stack #56 November 13, 2026 15:28
@bfabio
bfabio merged commit f273d65 into main Nov 13, 2026
10 checks passed
@bfabio
bfabio deleted the fix/keep-stored-publiccode-on-parse-failure branch November 13, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant